Since so many new items have entered review after Wednesday, I’m adding an extra summary post. You can find the weekly full post here.
SE-0130: Replace repeating Character and UnicodeScalar forms of String.init in review to 7/24. “This proposal suggest replacing String initializers taking Character or UnicodeScalar as a repeating value by a more general initializer that takes a String as a repeating value. This is done to avoid the ambiguities in the current String API, which can be only resolved by explicit casting. It is also proposed to remove one of the String.append APIs to match these changes.”
SE-0129: Package Manager Test Naming Conventions in review to 7/26. “Make the naming of tests be more predictable and more under the package author’s control. This is achieved in part by simplifying the naming conventions, and in part by reducing the number of differences between the conventions for the the
Tests and the
Sources top-level directories.”
SE-0128: Change failable UnicodeScalar initializers to failable in review to 7/24 “This proposal aims to change some (ones that are failable) UnicodeScalar initializers from non-failable to failable. i.e. in case a UnicodeScalar can not be constructed, nil is returned. Currently, when one passes an invalid value to the failable UnicodeScalar UInt32 initializer the swift stdlib crashes the program by calling _precondition. This is undesirable if one construct a unicode scalar from unknown input.”
SE-0127: Cleaning up stdlib Pointer and Buffer Routines in review to 7/24. “Update the API to match new API guidelines and remove redundant identifiers.”
SE-0126: Refactor Metatypes, repurpose T.self and Mirror in review to 7/24. “This proposal wants to revise metatypes
T.Type, repurpose public
T.self notation to return a new
Type<T> type instance rather than a metatype, merge SE-0101 into
Type<T>, rename the global function from SE-0096 to match the changes of this proposal and finally rename current
Mirror type to introduce a new (lazy)
SE-0117: Allow distinguishing between public access and public overridability revision 3 in review to 7/25 ” A
public member will only be usable by other modules, but not overridable. An
open member will be both usable and overridable. Similarly, a
public class will only be usable by other modules, but not subclassable. An
open class will be both usable and subclassable. This spirit of this proposal is to allow one to distinguish these cases while keeping them at the same level of support: it does not adversely affect code that is
open, nor does it dissuade one from using
open in their APIs. In fact, with this proposal,
open APIs are syntactically lighter-weight than
There’s a good roundup of (unhappy) opinion over at mjtsai.com.
Update: John McCall writes,
I’m resurrecting this thread to point out some minor revisions / clarifications that came up during implementation.
The first is that the accepted proposal contained “temporary” restrictions that required (1) open classes to subclass open classes and (2) open methods to override open methods. (2) is actually inconsistent with our existing access-control rules about overrides: the overridden method doesn’t even have to be public. Making a method open in a subclass shouldn’t force you to expose it in your superclass. Therefore, we have lifted this restriction. (1) is consistent with the access control rule on subclasses, so it has been conservatively kept; we’re still open to reconsidering this in the future.
The second is that the proposal wasn’t clear about how open interacts with initializers. There are many things about our current class-initialization design that are unsatisfactory, but we are not going to fix them in Swift 3. However, as a general matter, the clearest mental model for initializers is that every class provides its own, independent interface for constructing complete-objects / base-subobjects of that class. The initializers in each class are formally distinct from the initializers in their subclasses, even when they happen to have the same signature; they are not in any real sense “overrides” (even if in some cases we do currently require the “override” keyword). This is true even for required initializers, which merely state a requirement that all subclasses must provide a complete-object initializer with a particular signature, rather than expressing a real relationship between those initializers at each level. Furthermore, it is understood that constructing an object of a subclass necessarily involves delegating to that subclass; subclasses must always be able to initialize their portions of constructed objects. For all of these reasons, it is correct for initializers to not participate in open checking: they cannot be declared open, but correspondingly there are no restrictions on what initializers can be defined in a subclass, even if they have the same signature as an initializer from a superclass.
I have updated the proposal to reflect this.
Comments are closed.